linux-kernel - Re: [PATCH] btrfs: extend locking to all space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yh0zkPCdTlkFSfsQ@localhost.localdomain>
Date:   Mon, 28 Feb 2022 15:41:52 -0500
From:   Josef Bacik <josef@...icpanda.com>
To:     Niels Dossche <dossche.niels@...il.com>
Cc:     linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
        clm@...com, dsterba@...e.com,
        Niels Dossche <niels.dossche@...nt.be>
Subject: Re: [PATCH] btrfs: extend locking to all space_info members accesses

On Fri, Feb 25, 2022 at 10:20:28PM +0100, Niels Dossche wrote:
> bytes_pinned is always accessed under space_info->lock, except in
> btrfs_preempt_reclaim_metadata_space, however the other members are
> accessed under that lock. The reserved member of the rsv's are also
> partially accessed under a lock and partially not. Move all these
> accesses into the same lock to ensure consistency.
> 
> Signed-off-by: Niels Dossche <niels.dossche@...nt.be>
> Signed-off-by: Niels Dossche <dossche.niels@...il.com>

Reviewed-by: Josef Bacik <josef@...icpanda.com>

Thanks,

Josef