Date:   Mon, 28 Feb 2022 14:34:26 +0800
From:   Huacai Chen <chenhuacai@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Ard Biesheuvel <ardb@...nel.org>,
        Huacai Chen <chenhuacai@...ngson.cn>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Airlie <airlied@...ux.ie>,
        Jonathan Corbet <corbet@....net>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-arch <linux-arch@...r.kernel.org>,
        Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Xuefeng Li <lixuefeng@...ngson.cn>,
        Yanteng Si <siyanteng@...ngson.cn>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        linux-efi <linux-efi@...r.kernel.org>
Subject: Re: [PATCH V6 09/22] LoongArch: Add boot and setup routines

Hi, Ard and Greg,

On Mon, Feb 28, 2022 at 12:40 AM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> On Sun, Feb 27, 2022 at 03:14:30PM +0100, Ard Biesheuvel wrote:
> > (add Greg and ACPI maintainers)
> >
> > On Sat, 26 Feb 2022 at 12:11, Huacai Chen <chenhuacai@...ngson.cn> wrote:
> > >
> > > This patch adds basic boot, setup and reset routines for LoongArch.
> > > LoongArch uses UEFI-based firmware. The firmware uses ACPI and DMI/
> > > SMBIOS to pass configuration information to the Linux kernel (in elf
> > > format).
> > >
> > > Now the boot information passed to kernel is like this:
> > > 1, kernel get 3 register values (a0, a1 and a2) from bootloader.
> > > 2, a0 is "argc", a1 is "argv", so "kernel cmdline" comes from a0/a1.
> > > 3, a2 is "environ", which is a pointer to "struct bootparamsinterface".
> > > 4, "struct bootparamsinterface" include a "systemtable" pointer, whose
> > >    type is "efi_system_table_t". Most configuration information, include
> > >    ACPI tables and SMBIOS tables, come from here.
> > >
> > > Cc: Ard Biesheuvel <ardb@...nel.org>
> > > Cc: linux-efi@...r.kernel.org
> > > Signed-off-by: Huacai Chen <chenhuacai@...ngson.cn>
> > > ---
> > >  arch/loongarch/include/asm/acenv.h      |  17 +
> > >  arch/loongarch/include/asm/acpi.h       |  38 ++
> > >  arch/loongarch/include/asm/boot_param.h |  97 +++++
> > >  arch/loongarch/include/asm/bootinfo.h   |  33 ++
> > >  arch/loongarch/include/asm/dmi.h        |  24 ++
> > >  arch/loongarch/include/asm/efi.h        |  33 ++
> > >  arch/loongarch/include/asm/fw.h         |  18 +
> > >  arch/loongarch/include/asm/reboot.h     |  10 +
> > >  arch/loongarch/include/asm/setup.h      |  21 +
> > >  arch/loongarch/kernel/acpi.c            | 338 ++++++++++++++++
> > >  arch/loongarch/kernel/cacheinfo.c       | 122 ++++++
> > >  arch/loongarch/kernel/cmdline.c         |  31 ++
> > >  arch/loongarch/kernel/cpu-probe.c       | 305 +++++++++++++++
> > >  arch/loongarch/kernel/efi.c             | 208 ++++++++++
> > >  arch/loongarch/kernel/env.c             | 176 +++++++++
> > >  arch/loongarch/kernel/head.S            |  72 ++++
> > >  arch/loongarch/kernel/mem.c             |  89 +++++
> > >  arch/loongarch/kernel/reset.c           |  90 +++++
> > >  arch/loongarch/kernel/setup.c           | 495 ++++++++++++++++++++++++
> > >  arch/loongarch/kernel/time.c            | 220 +++++++++++
> > >  arch/loongarch/kernel/topology.c        |  13 +
> > >  21 files changed, 2450 insertions(+)
> >
> > As I pointed out in response to an earlier revision of this code, I
> > don't think we should merge this until we decide on some ground rules
> > regarding the support level of this architecture in the UEFI and ACPI
> > subsystems.
> >
> > The problem is that loongarch does not exist in the ACPI or UEFI
> > specifications at all, and as I understand it, the firmware
> > implementations themselves do not implement UEFI or ACPI entirely,
> > they simply present data structures in memory that look similar enough
> > for the Linux UEFI and ACPI code to boot the OS.
>
> Why isn't this in the ACPI/UEFI specs?  Is it a lack of access to the
> spec groups by the comapny making these devices, or something else?
We have tried our best to make LoongArch parts be in ACPI and UEFI SPECs.

ECR for adding LoongArch support in ACPI:
https://mantis.uefi.org/mantis/view.php?id=2203

ECR for adding LoongArch support in ACPI (version update):
https://mantis.uefi.org/mantis/view.php?id=2268

ECR for adding LoongArch support in UEFI:
https://mantis.uefi.org/mantis/view.php?id=2313

ACPI changes of LoongArch have been approved in the last year, but the
new version of ACPI SPEC hasn't been made public yet. And UEFI changes
of LoongArch are under review now.

Is it a must that the kernel code be merged after all SPECs are
public? If not, I think we can provide some snapshots (If it is legal,
I'm not sure) of mantis.uefi.org to prove the above.

Huacai

>
> > As the UEFI subsystem maintainer, I am concerned that future changes
> > to the UEFI subsystem that are rooted in the the UEFI specification as
> > it evolves may trigger unanticipated results on this architecture, and
> > I imagine the ACPI maintainers may have similar concerns.
>
> I agree, I would be concerned about that as well.
>
> > So what can we do about this? Do we merge this code, but as a second
> > class citizen in terms of UEFI/ACPI subsystem support, i.e., you are
> > welcome to use it, but if something breaks, the UEFI/ACPI maintainers
> > are not on the hook to see to it that it gets fixed? I don't think
> > this is a great solution, but I'm not sure if there are alternatives
> > that are any better.
>
> That's not going to work, it's the kernel's job to fix up hardware
> problems.  But as this is all firmware, why can't the firmware be
> changed to properly follow the public specifications?  What's wrong with
> requiring that at this point in time (i.e. _BEFORE_ the code is merged)?
>
> thanks,
>
> greg k-h

Powered by blists - more mailing lists