linux-kernel - Re: [PATCH] mfd: Avoid unused variable 'atmel_flexcom_pm_ops' warning

Open Source and information security mailing list archives

Date:   Mon, 28 Feb 2022 07:36:09 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <groeck@...gle.com>, <shraash@...gle.com>
CC:     <alexandre.belloni@...tlin.com>, <linux-kernel@...r.kernel.org>,
        <Ludovic.Desroches@...rochip.com>, <groeck@...omium.org>,
        <lee.jones@...aro.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] mfd: Avoid unused variable 'atmel_flexcom_pm_ops' warning

On 25.02.2022 21:00, Guenter Roeck wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Fri, Feb 25, 2022 at 2:15 AM Aashish Sharma <shraash@...gle.com> wrote:
>>
>> Fix this kernel test robot warning:
>>
>> drivers/mfd/atmel-flexcom.c:108:32: warning: unused
>> variable 'atmel_flexcom_pm_ops' [-Wunused-const-variable]
>>
>> The variable atmel_flexcom_pm_ops is unused when CONFIG_PM
>> is not selected, so marking it as __maybe_unsed.
>>
>> Signed-off-by: Aashish Sharma <shraash@...gle.com>
> 
> Reviewed-by: Guenter Roeck <groeck@...gle.com>

There is already [1] posted a while ago...

[1] https://lkml.org/lkml/2021/12/7/474

> 
>> ---
>>  drivers/mfd/atmel-flexcom.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
>> index 559eb4d352b6..33caa4fba6af 100644
>> --- a/drivers/mfd/atmel-flexcom.c
>> +++ b/drivers/mfd/atmel-flexcom.c
>> @@ -105,7 +105,7 @@ static int __maybe_unused atmel_flexcom_resume_noirq(struct device *dev)
>>         return 0;
>>  }
>>
>> -static const struct dev_pm_ops atmel_flexcom_pm_ops = {
>> +static const struct dev_pm_ops __maybe_unused atmel_flexcom_pm_ops = {
>>         .resume_noirq = atmel_flexcom_resume_noirq,
>>  };
>>
>> --
>> 2.35.1.574.g5d30c73bfb-goog
>>
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives