linux-kernel - Re: [PATCH] mfd: Avoid unused variable 'atmel_flexcom_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 25 Feb 2022 11:00:17 -0800
From:   Guenter Roeck <groeck@...gle.com>
To:     Aashish Sharma <shraash@...gle.com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        "moderated list:ARM PORT" <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Guenter Roeck <groeck@...omium.org>
Subject: Re: [PATCH] mfd: Avoid unused variable 'atmel_flexcom_pm_ops' warning

On Fri, Feb 25, 2022 at 2:15 AM Aashish Sharma <shraash@...gle.com> wrote:
>
> Fix this kernel test robot warning:
>
> drivers/mfd/atmel-flexcom.c:108:32: warning: unused
> variable 'atmel_flexcom_pm_ops' [-Wunused-const-variable]
>
> The variable atmel_flexcom_pm_ops is unused when CONFIG_PM
> is not selected, so marking it as __maybe_unsed.
>
> Signed-off-by: Aashish Sharma <shraash@...gle.com>

Reviewed-by: Guenter Roeck <groeck@...gle.com>

> ---
>  drivers/mfd/atmel-flexcom.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
> index 559eb4d352b6..33caa4fba6af 100644
> --- a/drivers/mfd/atmel-flexcom.c
> +++ b/drivers/mfd/atmel-flexcom.c
> @@ -105,7 +105,7 @@ static int __maybe_unused atmel_flexcom_resume_noirq(struct device *dev)
>         return 0;
>  }
>
> -static const struct dev_pm_ops atmel_flexcom_pm_ops = {
> +static const struct dev_pm_ops __maybe_unused atmel_flexcom_pm_ops = {
>         .resume_noirq = atmel_flexcom_resume_noirq,
>  };
>
> --
> 2.35.1.574.g5d30c73bfb-goog
>