linux-kernel - RE: [PATCH] hv_balloon: rate-limit "Unhandled message" warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN0PR21MB3098049BCEFAAEE5C61F589AD73E9@MN0PR21MB3098.namprd21.prod.outlook.com>
Date:   Fri, 25 Feb 2022 18:59:18 +0000
From:   "Michael Kelley (LINUX)" <mikelley@...rosoft.com>
To:     Anssi Hannula <anssi.hannula@...wise.fi>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>
CC:     "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] hv_balloon: rate-limit "Unhandled message" warning

From: Anssi Hannula <anssi.hannula@...wise.fi> Sent: Tuesday, February 22, 2022 6:14 AM
> 
> For a couple of times I have encountered a situation where
> 
>   hv_balloon: Unhandled message: type: 12447
> 
> is being flooded over 1 million times per second with various values,
> filling the log and consuming cycles, making debugging difficult.
> 
> Add rate limiting to the message.
> 
> Most other Hyper-V drivers already have similar rate limiting in their
> message callbacks.
> 
> The cause of the floods in my case was probably fixed by 96d9d1fa5cd5
> ("Drivers: hv: balloon: account for vmbus packet header in
> max_pkt_size").
> 
> Fixes: 9aa8b50b2b3d ("Drivers: hv: Add Hyper-V balloon driver")
> Signed-off-by: Anssi Hannula <anssi.hannula@...wise.fi>
> ---
>  drivers/hv/hv_balloon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c
> index f2d05bff4245..439f99b8b5de 100644
> --- a/drivers/hv/hv_balloon.c
> +++ b/drivers/hv/hv_balloon.c
> @@ -1563,7 +1563,7 @@ static void balloon_onchannelcallback(void *context)
>                         break;
> 
>                 default:
> -                       pr_warn("Unhandled message: type: %d\n", dm_hdr->type);
> +                       pr_warn_ratelimited("Unhandled message: type: %d\n", dm_hdr->type);
> 
>                 }
>         }
> --
> 2.34.1

Unlike some of the other VMbus drivers, this driver has not been "hardened" for
use in an environment where the guest does not trust the hypervisor, but it was
affected by changes to the underlying ring buffer handling.  The bug that caused
the flood of errors has indeed been fixed, but I'm good with rate limiting this
warning.

Reviewed-by: Michael Kelley <mikelley@...rosoft.com>