linux-kernel - Re: [PATCH] hv_balloon: rate-limit "Unhandled message" warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220301151605.j5zymunttpylphyn@liuwe-devbox-debian-v2>
Date:   Tue, 1 Mar 2022 15:16:05 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     "Michael Kelley (LINUX)" <mikelley@...rosoft.com>
Cc:     Anssi Hannula <anssi.hannula@...wise.fi>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] hv_balloon: rate-limit "Unhandled message" warning

On Fri, Feb 25, 2022 at 06:59:18PM +0000, Michael Kelley (LINUX) wrote:
> From: Anssi Hannula <anssi.hannula@...wise.fi> Sent: Tuesday, February 22, 2022 6:14 AM
> > 
> > For a couple of times I have encountered a situation where
> > 
> >   hv_balloon: Unhandled message: type: 12447
> > 
> > is being flooded over 1 million times per second with various values,
> > filling the log and consuming cycles, making debugging difficult.
> > 
> > Add rate limiting to the message.
> > 
> > Most other Hyper-V drivers already have similar rate limiting in their
> > message callbacks.
> > 
> > The cause of the floods in my case was probably fixed by 96d9d1fa5cd5
> > ("Drivers: hv: balloon: account for vmbus packet header in
> > max_pkt_size").
> > 
> > Fixes: 9aa8b50b2b3d ("Drivers: hv: Add Hyper-V balloon driver")
> > Signed-off-by: Anssi Hannula <anssi.hannula@...wise.fi>
[...]
> 
> Reviewed-by: Michael Kelley <mikelley@...rosoft.com>

Applied to hyperv-next. Thanks.