linux-kernel - Re: [PATCH] mm/oom_kill: remove unneeded is_memcg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YhzmHHxDs9lnFajc@dhcp22.suse.cz>
Date:   Mon, 28 Feb 2022 16:11:24 +0100
From:   Michal Hocko <mhocko@...e.com>
To:     Miaohe Lin <linmiaohe@...wei.com>
Cc:     akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/oom_kill: remove unneeded is_memcg_oom check

On Thu 24-02-22 19:59:33, Miaohe Lin wrote:
> oom_cpuset_eligible is always called when !is_memcg_oom. Remove this
> unnecessary check.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>

Acked-by: Michal Hocko <mhocko@...e.com>
Thanks!

> ---
>  mm/oom_kill.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> index 9fea6d3c1ec7..c70a4330e548 100644
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -122,9 +122,6 @@ static bool oom_cpuset_eligible(struct task_struct *start,
>  	bool ret = false;
>  	const nodemask_t *mask = oc->nodemask;
>  
> -	if (is_memcg_oom(oc))
> -		return true;
> -
>  	rcu_read_lock();
>  	for_each_thread(start, tsk) {
>  		if (mask) {
> -- 
> 2.23.0

-- 
Michal Hocko
SUSE Labs