linux-kernel - Re: [PATCH] scsi: wd719x: Return proper error code when dma_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR04MB7416EBC9CA1843989E252CA49B019@PH0PR04MB7416.namprd04.prod.outlook.com>
Date:   Mon, 28 Feb 2022 15:43:06 +0000
From:   Johannes Thumshirn <Johannes.Thumshirn@....com>
To:     Zheyu Ma <zheyuma97@...il.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: wd719x: Return proper error code when
 dma_set_mask() fails

On 28/02/2022 15:54, Zheyu Ma wrote:
> During the process of driver probing, the probe function should return < 0
> for failure, otherwise, the kernel will treat value >= 0 as success.

"So set 'err' to the error value returned by dma_set_mask() in case of failure"

Otherwise looks good to me,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@....com>