linux-kernel - Re: [PATCH] soc: microchip: make mpfs_sys_controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2y2j=zSsPtAFDZxv9b_e2SG6V5DBy__voiHRnDw5n4Aw@mail.gmail.com>
Date:   Mon, 28 Feb 2022 16:42:52 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Conor Dooley <mail@...chuod.ie>
Cc:     conor.dooley@...rochip.com,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>,
        linux-riscv <linux-riscv@...ts.infradead.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] soc: microchip: make mpfs_sys_controller_put static

On Sat, Feb 26, 2022 at 1:48 PM Conor Dooley <mail@...chuod.ie> wrote:
>
> From: Conor Dooley <conor.dooley@...rochip.com>
>
> dsafsdfd0054 ("soc: add microchip polarfire soc system controller")
> incorrectly exported mpfs_sys_controller_put. Remove the export and make
> the function static instead. This fixes the "no previous prototype
> for 'mpfs_sys_controller_put'" warning spotted by the kernel test robot.
>
> Fixes: dsafsdfd0054 ("soc: add microchip polarfire soc system
> controller")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> Signed-off-by: Conor Dooley <mail@...chuod.ie>

For reference, I saw the same report and added a different fix for  this
at first, but replaced it with this patch now. No need to add it to the at91
tree. Nicolas, in case there is another problem with this patch, let me know.

       Arnd