linux-kernel - [PATCH] locking/rwbase: Return true/false (not 1/0) from bool functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1646103358-21591-1-git-send-email-baihaowen88@gmail.com>
Date:   Tue,  1 Mar 2022 10:55:58 +0800
From:   Haowen Bai <baihaowen88@...il.com>
To:     peterz@...radead.org, mingo@...hat.com, will@...nel.org
Cc:     longman@...hat.com, boqun.feng@...il.com,
        linux-kernel@...r.kernel.org, Haowen Bai <baihaowen88@...il.com>
Subject: [PATCH] locking/rwbase: Return true/false (not 1/0) from bool functions

Return boolean values ("true" or "false") instead of 1 or 0 from bool 
functions.  This fixes the following warnings from coccicheck:

kernel/locking/rwbase_rt.c:226:9-10: WARNING: return of 0/1 in function '__rwbase_write_trylock' with return type bool


Signed-off-by: Haowen Bai <baihaowen88@...il.com>
---
 kernel/locking/rwbase_rt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/locking/rwbase_rt.c b/kernel/locking/rwbase_rt.c
index 6fd3162..e3dd458 100644
--- a/kernel/locking/rwbase_rt.c
+++ b/kernel/locking/rwbase_rt.c
@@ -223,10 +223,10 @@ static inline bool __rwbase_write_trylock(struct rwbase_rt *rwb)
 	 */
 	if (!atomic_read_acquire(&rwb->readers)) {
 		atomic_set(&rwb->readers, WRITER_BIAS);
-		return 1;
+		return true;
 	}
 
-	return 0;
+	return false;
 }
 
 static int __sched rwbase_write_lock(struct rwbase_rt *rwb,
-- 
2.7.4