linux-kernel - Re: [PATCH] x86/acpi: Work around broken XSDT on SEGA AALE board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gPxZ_m=7bqgo54kb1Kx5ut_KZ2iOeWo2ak0AFJq7rpjw@mail.gmail.com>
Date:   Wed, 2 Mar 2022 20:42:43 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Mark Cilissen <mark@...suba.nl>,
        Hans de Goede <hdegoede@...hat.com>
Cc:     ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <len.brown@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        "the arch/x86 maintainers" <x86@...nel.org>
Subject: Re: [PATCH] x86/acpi: Work around broken XSDT on SEGA AALE board

On Tue, Mar 1, 2022 at 8:34 PM Rafael J. Wysocki <rafael@...nel.org> wrote:
>
> On Thu, Feb 24, 2022 at 9:41 AM Hans de Goede <hdegoede@...hat.com> wrote:
> >
> > Hi Mark,
> >
> > On 2/23/22 17:07, Mark Cilissen wrote:
> > > On this board the ACPI RSDP structure points to both a RSDT and an XSDT,
> > > but the XSDT points to a truncated FADT. This causes all sorts of trouble
> > > and usually a complete failure to boot after the following error occurs:
> > >
> > >   ACPI Error: Unsupported address space: 0x20 (*/hwregs-*)
> > >   ACPI Error: AE_SUPPORT, Unable to initialize fixed events (*/evevent-*)
> > >   ACPI: Unable to start ACPI Interpreter
> > >
> > > This leaves the ACPI implementation in such a broken state that subsequent
> > > kernel subsystem initialisations go wrong, resulting in among others
> > > mismapped PCI memory, SATA and USB enumeration failures, and freezes.
> > >
> > > As this is an older embedded platform that will likely never see any BIOS
> > > updates to address this issue and its default shipping OS only complies to
> > > ACPI 1.0, work around this by forcing `acpi=rsdt`. This patch, applied on
> > > top of Linux 5.10.102, was confirmed on real hardware to fix the issue.
> > >
> > > Signed-off-by: Mark Cilissen <mark@...suba.nl>
> > > Cc: stable@...r.kernel.org
> >
> > Wow, you got it working, cool!
> >
> > The patch looks good to me:
> >
> > Reviewed-by: Hans de Goede <hdegoede@...hat.com>
>
> Applied as 5.18 material, thanks!

And dropped due to a problem introduced by it.

Also please note that the x86 mailing list address originally used in
the CC list was incorrect.