lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Yh/22twvqyRsSy7P@gondor.apana.org.au> Date: Thu, 3 Mar 2022 10:59:38 +1200 From: Herbert Xu <herbert@...dor.apana.org.au> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Cc: linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org, "David S. Miller" <davem@...emloft.net> Subject: Re: [PATCH v2 1/1] crypto: cavium/nitrox - don't cast parameter in bit operations On Wed, Feb 23, 2022 at 06:26:20PM +0200, Andy Shevchenko wrote: > While in this particular case it would not be a (critical) issue, > the pattern itself is bad and error prone in case the location > of the parameter is changed. > > Don't cast parameter to unsigned long pointer in the bit operations. > Instead copy to a local variable on stack of a proper type and use. > > Fixes: cf718eaa8f9b ("crypto: cavium/nitrox - Enabled Mailbox support") > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> > --- > v2: fixed typo (LKP, Herbert) > drivers/crypto/cavium/nitrox/nitrox_mbx.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Powered by blists - more mailing lists