[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Yh+Rla5X7/8MBybu@smile.fi.intel.com>
Date: Wed, 2 Mar 2022 17:47:33 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Herbert Xu <herbert@...dor.apana.org.au>,
"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH v2 1/1] crypto: cavium/nitrox - don't cast parameter in
bit operations
On Wed, Feb 23, 2022 at 06:26:20PM +0200, Andy Shevchenko wrote:
> While in this particular case it would not be a (critical) issue,
> the pattern itself is bad and error prone in case the location
> of the parameter is changed.
>
> Don't cast parameter to unsigned long pointer in the bit operations.
> Instead copy to a local variable on stack of a proper type and use.
Is this fix already applied?
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists