linux-kernel - Re: [PATCH v8 2/2] clocksource: Add Intel Keem Bay timer support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yh925VvqejDe2SR8@smile.fi.intel.com>
Date:   Wed, 2 Mar 2022 15:53:41 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     shruthi.sanil@...el.com, tglx@...utronix.de, robh+dt@...nel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        mgross@...ux.intel.com, srikanth.thokala@...el.com,
        lakshmi.bai.raja.subramanian@...el.com,
        mallikarjunappa.sangannavar@...el.com
Subject: Re: [PATCH v8 2/2] clocksource: Add Intel Keem Bay timer support

On Tue, Mar 01, 2022 at 10:09:06PM +0100, Daniel Lezcano wrote:
> On 22/02/2022 10:56, shruthi.sanil@...el.com wrote:

> > +		/* Clear interrupt for periodic timer*/
> 
> nit: comment format is:
> 
> /*
>  * my comment
>  */
> 
> One line comment format is usually for the network subsystem

Huh?
Any pointers to the documentation, please?

> > +		keembay_timer_clear_pending_int(tim_base);
> > +	} else {
> > +		/* Disable the timer for one shot timer */
> 
> comment format
> 
> > +		keembay_timer_disable(tim_base);
> > +	}

-- 
With Best Regards,
Andy Shevchenko