linux-kernel - [jirislaby:devel 1/26] drivers/tty/serial/sunplus-uart.c:526:7: error: incompatible function pointer types passing 'void (struct uart_port *, int)' to parameter of type 'void (*)(struct uart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202203022325.0pJF6ttl-lkp@intel.com>
Date:   Thu, 3 Mar 2022 00:03:19 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jiri Slaby <jslaby@...e.cz>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: [jirislaby:devel 1/26] drivers/tty/serial/sunplus-uart.c:526:7:
 error: incompatible function pointer types passing 'void (struct uart_port
 *, int)' to parameter of type 'void (*)(struct uart_port *, unsigned char)'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git devel
head:   7191d41e22ce0a4e950f14966bad50b609e1bae5
commit: 5382fe2c6cd08c05c0def9d3bf422a2a454a5ff9 [1/26] serial: make uart_console_write->putchar()'s character an unsigned char
config: hexagon-randconfig-r001-20220302 (https://download.01.org/0day-ci/archive/20220302/202203022325.0pJF6ttl-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git/commit/?id=5382fe2c6cd08c05c0def9d3bf422a2a454a5ff9
        git remote add jirislaby https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git
        git fetch --no-tags jirislaby devel
        git checkout 5382fe2c6cd08c05c0def9d3bf422a2a454a5ff9
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/tty/serial/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/tty/serial/sunplus-uart.c:526:7: error: incompatible function pointer types passing 'void (struct uart_port *, int)' to parameter of type 'void (*)(struct uart_port *, unsigned char)' [-Werror,-Wincompatible-function-pointer-types]
                              sunplus_uart_console_putchar);
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/serial_core.h:402:11: note: passing argument to parameter 'putchar' here
                           void (*putchar)(struct uart_port *, unsigned char));
                                  ^
   drivers/tty/serial/sunplus-uart.c:752:39: error: incompatible function pointer types passing 'void (struct uart_port *, int)' to parameter of type 'void (*)(struct uart_port *, unsigned char)' [-Werror,-Wincompatible-function-pointer-types]
           uart_console_write(&dev->port, s, n, sunplus_uart_putc);
                                                ^~~~~~~~~~~~~~~~~
   include/linux/serial_core.h:402:11: note: passing argument to parameter 'putchar' here
                           void (*putchar)(struct uart_port *, unsigned char));
                                  ^
   2 errors generated.


vim +526 drivers/tty/serial/sunplus-uart.c

9e8d5470325f25 Hammer Hsieh 2022-02-22  508  
9e8d5470325f25 Hammer Hsieh 2022-02-22  509  static void sunplus_console_write(struct console *co,
9e8d5470325f25 Hammer Hsieh 2022-02-22  510  				  const char *s,
9e8d5470325f25 Hammer Hsieh 2022-02-22  511  				  unsigned int count)
9e8d5470325f25 Hammer Hsieh 2022-02-22  512  {
9e8d5470325f25 Hammer Hsieh 2022-02-22  513  	unsigned long flags;
9e8d5470325f25 Hammer Hsieh 2022-02-22  514  	int locked = 1;
9e8d5470325f25 Hammer Hsieh 2022-02-22  515  
9e8d5470325f25 Hammer Hsieh 2022-02-22  516  	local_irq_save(flags);
9e8d5470325f25 Hammer Hsieh 2022-02-22  517  
9e8d5470325f25 Hammer Hsieh 2022-02-22  518  	if (sunplus_console_ports[co->index]->port.sysrq)
9e8d5470325f25 Hammer Hsieh 2022-02-22  519  		locked = 0;
9e8d5470325f25 Hammer Hsieh 2022-02-22  520  	else if (oops_in_progress)
9e8d5470325f25 Hammer Hsieh 2022-02-22  521  		locked = spin_trylock(&sunplus_console_ports[co->index]->port.lock);
9e8d5470325f25 Hammer Hsieh 2022-02-22  522  	else
9e8d5470325f25 Hammer Hsieh 2022-02-22  523  		spin_lock(&sunplus_console_ports[co->index]->port.lock);
9e8d5470325f25 Hammer Hsieh 2022-02-22  524  
9e8d5470325f25 Hammer Hsieh 2022-02-22  525  	uart_console_write(&sunplus_console_ports[co->index]->port, s, count,
9e8d5470325f25 Hammer Hsieh 2022-02-22 @526  			   sunplus_uart_console_putchar);
9e8d5470325f25 Hammer Hsieh 2022-02-22  527  
9e8d5470325f25 Hammer Hsieh 2022-02-22  528  	if (locked)
9e8d5470325f25 Hammer Hsieh 2022-02-22  529  		spin_unlock(&sunplus_console_ports[co->index]->port.lock);
9e8d5470325f25 Hammer Hsieh 2022-02-22  530  
9e8d5470325f25 Hammer Hsieh 2022-02-22  531  	local_irq_restore(flags);
9e8d5470325f25 Hammer Hsieh 2022-02-22  532  }
9e8d5470325f25 Hammer Hsieh 2022-02-22  533  

:::::: The code at line 526 was first introduced by commit
:::::: 9e8d5470325f25bed7d33f9faaae6d5e4f313650 serial: sunplus-uart: Add Sunplus SoC UART Driver

:::::: TO: Hammer Hsieh <hammerh0314@...il.com>
:::::: CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org