lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 3 Mar 2022 12:36:57 +0200 From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> To: Tyrone Ting <warp5tw@...il.com> Cc: avifishman70@...il.com, tmaimon77@...il.com, tali.perry1@...il.com, venture@...gle.com, yuenn@...gle.com, benjaminfair@...gle.com, robh+dt@...nel.org, krzysztof.kozlowski@...onical.com, yangyicong@...ilicon.com, semen.protsenko@...aro.org, wsa@...nel.org, jie.deng@...el.com, sven@...npeter.dev, bence98@....bme.hu, lukas.bulwahn@...il.com, arnd@...db.de, olof@...om.net, tali.perry@...oton.com, Avi.Fishman@...oton.com, tomer.maimon@...oton.com, KWLIU@...oton.com, JJLIU0@...oton.com, kfting@...oton.com, openbmc@...ts.ozlabs.org, linux-i2c@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v3 09/11] i2c: npcm: Handle spurious interrupts On Thu, Mar 03, 2022 at 04:31:39PM +0800, Tyrone Ting wrote: > From: Tali Perry <tali.perry1@...il.com> > > In order to better handle spurious interrupts: > 1. Disable incoming interrupts in master only mode. > 2. Clear end of busy (EOB) after every interrupt. > 3. Return correct status during interrupt. This is bad commit message, it doesn't explain "why" you are doing these. ... > + /* > + * if irq is not one of the above, make sure EOB is disabled and all > + * status bits are cleared. This does not explain why you hide the spurious interrupt. > + */ > + if (ret == IRQ_NONE) { > + npcm_i2c_eob_int(bus, false); > + npcm_i2c_clear_master_status(bus); > + } > + > + return IRQ_HANDLED; -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists