linux-kernel - Re: [PATCH] KVM: x86: mmu: trace kvm_mmu_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Mar 2022 16:56:53 +0000
From:   Sean Christopherson <seanjc@...gle.com>
To:     Maxim Levitsky <mlevitsk@...hat.com>
Cc:     kvm@...r.kernel.org, Joerg Roedel <joro@...tes.org>,
        x86@...nel.org, Jim Mattson <jmattson@...gle.com>,
        linux-kernel@...r.kernel.org, Wanpeng Li <wanpengli@...cent.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Borislav Petkov <bp@...en8.de>, Ingo Molnar <mingo@...hat.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] KVM: x86: mmu: trace kvm_mmu_set_spte after the new SPTE
 was set

On Wed, Mar 02, 2022, Maxim Levitsky wrote:
> It makes more sense to print new SPTE value than the
> old value.
> 

  Fixes: d786c7783b01 ("KVM: MMU: inline set_spte in mmu_set_spte")

And arguably even Cc: stable@...r.kernel.org, though that's unnecessary if this
gets into 5.17, which it should.

Reviewed-by: Sean Christopherson <seanjc@...gle.com>

> Signed-off-by: Maxim Levitsky <mlevitsk@...hat.com>
> ---
>  arch/x86/kvm/mmu/mmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
> index 94f077722b290..0e209f0b2e1d2 100644
> --- a/arch/x86/kvm/mmu/mmu.c
> +++ b/arch/x86/kvm/mmu/mmu.c
> @@ -2690,8 +2690,8 @@ static int mmu_set_spte(struct kvm_vcpu *vcpu, struct kvm_memory_slot *slot,
>  	if (*sptep == spte) {
>  		ret = RET_PF_SPURIOUS;
>  	} else {
> -		trace_kvm_mmu_set_spte(level, gfn, sptep);
>  		flush |= mmu_spte_update(sptep, spte);
> +		trace_kvm_mmu_set_spte(level, gfn, sptep);
>  	}
>  
>  	if (wrprot) {
> -- 
> 2.26.3>