linux-kernel - Re: [PATCH] Documentation/locking/locktypes: Fix PREEMPT_RT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <875yothc8l.fsf@meer.lwn.net>
Date:   Fri, 04 Mar 2022 10:13:46 -0700
From:   Jonathan Corbet <corbet@....net>
To:     Andrew Halaney <ahalaney@...hat.com>
Cc:     peterz@...radead.org, mingo@...hat.com, will@...nel.org,
        longman@...hat.com, boqun.feng@...il.com,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andrew Halaney <ahalaney@...hat.com>,
        Leah Leshchinsky <lleshchi@...hat.com>
Subject: Re: [PATCH] Documentation/locking/locktypes: Fix PREEMPT_RT _bh()
 description

Andrew Halaney <ahalaney@...hat.com> writes:

> With PREEMPT_RT the _bh() version of a spinlock leaves preemption
> enabled, align the doc to say that instead of the opposite.
>
> Reported-by: Leah Leshchinsky <lleshchi@...hat.com>
> Signed-off-by: Andrew Halaney <ahalaney@...hat.com>
> ---
>  Documentation/locking/locktypes.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/locking/locktypes.rst b/Documentation/locking/locktypes.rst
> index 4fd7b70fcde1..bfa75ea1b66a 100644
> --- a/Documentation/locking/locktypes.rst
> +++ b/Documentation/locking/locktypes.rst
> @@ -247,7 +247,7 @@ based on rt_mutex which changes the semantics:
>     Non-PREEMPT_RT kernels disable preemption to get this effect.
>  
>     PREEMPT_RT kernels use a per-CPU lock for serialization which keeps
> -   preemption disabled. The lock disables softirq handlers and also
> +   preemption enabled. The lock disables softirq handlers and also
>     prevents reentrancy due to task preemption.

Applied, thanks.

jon