linux-kernel - Re: [PATCH] Documentation/locking/locktypes: Fix PREEMPT_RT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yhg9SU353e+Gh5Jg@boqun-archlinux>
Date:   Fri, 25 Feb 2022 10:22:01 +0800
From:   Boqun Feng <boqun.feng@...il.com>
To:     Andrew Halaney <ahalaney@...hat.com>
Cc:     corbet@....net, peterz@...radead.org, mingo@...hat.com,
        will@...nel.org, longman@...hat.com, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Leah Leshchinsky <lleshchi@...hat.com>
Subject: Re: [PATCH] Documentation/locking/locktypes: Fix PREEMPT_RT _bh()
 description

On Thu, Feb 24, 2022 at 03:23:12PM -0600, Andrew Halaney wrote:
> With PREEMPT_RT the _bh() version of a spinlock leaves preemption
> enabled, align the doc to say that instead of the opposite.
> 
> Reported-by: Leah Leshchinsky <lleshchi@...hat.com>
> Signed-off-by: Andrew Halaney <ahalaney@...hat.com>

Reviewed-by: Boqun Feng <boqun.feng@...il.com>

Regards,
Boqun

> ---
>  Documentation/locking/locktypes.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/locking/locktypes.rst b/Documentation/locking/locktypes.rst
> index 4fd7b70fcde1..bfa75ea1b66a 100644
> --- a/Documentation/locking/locktypes.rst
> +++ b/Documentation/locking/locktypes.rst
> @@ -247,7 +247,7 @@ based on rt_mutex which changes the semantics:
>     Non-PREEMPT_RT kernels disable preemption to get this effect.
>  
>     PREEMPT_RT kernels use a per-CPU lock for serialization which keeps
> -   preemption disabled. The lock disables softirq handlers and also
> +   preemption enabled. The lock disables softirq handlers and also
>     prevents reentrancy due to task preemption.
>  
>  PREEMPT_RT kernels preserve all other spinlock_t semantics:
> -- 
> 2.35.1
>