linux-kernel - Re: [PATCH] arm64: dts: renesas: falcon-cpu: Use INTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdU+sO+LAOxaSfN6aLa4ROnF71j=RQVqk_1jAfvjYyeCwA@mail.gmail.com>
Date:   Fri, 4 Mar 2022 13:37:34 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
Cc:     Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Magnus Damm <magnus.damm@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: renesas: falcon-cpu: Use INTC_EX for SN65DSI86

Hi Kieran,

On Fri, Mar 4, 2022 at 12:41 PM Kieran Bingham
<kieran.bingham+renesas@...asonboard.com> wrote:
> The INTC block is a better choice for handling the interrupts on the V3U
> as the INTC will always be powered, while the GPIO block may be
> de-clocked if not in use. Further more, it may be likely to have a lower
> power consumption as it does not need to drive the pins.
>
> Switch the interrupt parent and interrupts definition from gpio1 to
> intc_ex, allowing the PFC to configure the pin muxing accordingly.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi
> @@ -198,8 +198,8 @@ bridge@2c {
>                 clocks = <&sn65dsi86_refclk>;
>                 clock-names = "refclk";
>
> -               interrupt-parent = <&gpio1>;
> -               interrupts = <24 IRQ_TYPE_LEVEL_HIGH>;
> +               interrupt-parent = <&intc_ex>;
> +               interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
>
>                 vccio-supply = <&reg_1p8v>;
>                 vpll-supply = <&reg_1p8v>;

The above is correct, but you forgot to configure pin control for the
irq0 pin.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds