linux-kernel - Re: [PATCH 2/2] pinctrl: ocelot: Fix interrupt parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YiII4mMembqLiX5D@smile.fi.intel.com>
Date:   Fri, 4 Mar 2022 14:41:06 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc:     linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linus.walleij@...aro.org, colin.foster@...advantage.com
Subject: Re: [PATCH 2/2] pinctrl: ocelot: Fix interrupt parsing

On Fri, Mar 04, 2022 at 02:40:38PM +0200, Andy Shevchenko wrote:
> On Thu, Mar 03, 2022 at 09:37:16PM +0100, Horatiu Vultur wrote:
> > In the blamed commit, it removes the duplicate of_node assignment in the
> > driver. But the driver uses this before calling into of_gpio_dev_init to
> > determine if it needs to assign an IRQ chip to the GPIO. The fixes
> > consists in using of_node from dev.
> 
> ...
> 
> > -	irq = irq_of_parse_and_map(gc->of_node, 0);
> > +	irq = irq_of_parse_and_map(info->dev->of_node, 0);
> 
> Why platform_get_irq() can't be used?

Or actually _optional() variant of it?

-- 
With Best Regards,
Andy Shevchenko