linux-kernel - Re: [PATCH] mmc: core: Restore (almost) the busy polling for MMC_SEND_OP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220304160513.GA1361@math.uni-bielefeld.de>
Date:   Fri, 4 Mar 2022 17:05:14 +0100
From:   Jean Rene Dawin <jdawin@...h.uni-bielefeld.de>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     linux-mmc@...r.kernel.org,
        "H . Nikolaus Schaller" <hns@...delico.com>,
        Huijin Park <huijin.park@...sung.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: core: Restore (almost) the busy polling for
 MMC_SEND_OP_COND

Ulf Hansson wrote on Fri  4/03/22 11:56:
> Commit 76bfc7ccc2fa ("mmc: core: adjust polling interval for CMD1"),
> significantly decreased the polling period from ~10-12ms into just a couple
> of us. The purpose was to decrease the total time spent in the busy polling
> loop, but unfortunate it has lead to problems, that causes eMMC cards to
> never gets out busy and thus fails to be initialized.
> 
> To fix the problem, but also to try to keep some of the new improved
> behaviour, let's start by using a polling period of 1-2ms, which then
> increases for each loop, according to common polling loop in
> __mmc_poll_for_busy().
> 
> Reported-by: Jean Rene Dawin <jdawin@...h.uni-bielefeld.de>
> Reported-by: H. Nikolaus Schaller <hns@...delico.com>
> Cc: Huijin Park <huijin.park@...sung.com>
> Fixes: 76bfc7ccc2fa ("mmc: core: adjust polling interval for CMD1")
> Signed-off-by: Ulf Hansson <ulf.hansson@...aro.org>
> ---
> 
> Jean Rene and H. Nikolaus, if this doesn't work, please try extending the
> the MMC_OP_COND_PERIOD_US a bit, to so see if we can find a value that always
> works.
> 
> Kind regards
> Uffe
> 
> ---
>  drivers/mmc/core/block.c   |  2 +-
>  drivers/mmc/core/mmc.c     |  2 +-
>  drivers/mmc/core/mmc_ops.c | 13 +++++++++----
>  drivers/mmc/core/mmc_ops.h |  3 ++-
>  drivers/mmc/core/sd.c      |  2 +-
>  5 files changed, 14 insertions(+), 8 deletions(-)

Hi,

thanks, this works fine.

Regads,
Jean Rene Dawin