linux-kernel - Re: [PATCH v2 2/6] ASoC: dt-bindings: Document Microchip's PDMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38975dd7-2f54-8920-af28-0a002f0faf5e@microchip.com>
Date:   Mon, 7 Mar 2022 11:34:35 +0000
From:   <Codrin.Ciubotariu@...rochip.com>
To:     <krzysztof.kozlowski@...onical.com>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
CC:     <lars@...afoo.de>, <broonie@...nel.org>, <perex@...ex.cz>,
        <tiwai@...e.com>, <robh+dt@...nel.org>,
        <Nicolas.Ferre@...rochip.com>
Subject: Re: [PATCH v2 2/6] ASoC: dt-bindings: Document Microchip's PDMC

On 07.03.2022 13:18, Krzysztof Kozlowski wrote:
> On 07/03/2022 11:04, Codrin Ciubotariu wrote:
>> +description:
>> +  The Microchip Pulse Density Microphone Controller (PDMC) interfaces up to 4 digital microphones
>> +  having Pulse Density Modulated (PDM) outputs.
> 
> This exceeds 80 characters.

I thought it was raised to 100. checkpatch doesn't report anything also.

>> +  microchip,mic-pos:
>> +    description: |
>> +      Position of PDM microphones on the DS line and the sampling edge (rising or falling) of the
>> +      CLK line. A microphone is represented as a pair of DS line and the sampling edge. The first
>> +      microphone is mapped to channel 0, the second to channel 1, etc.
> 
> This is also too long, wrap at 80.

ok...

>> +    pdmc: sound@...08000 {
>> +        compatible = "microchip,sama7g5-pdmc";
>> +        #sound-dai-cells = <0>;
>> +        reg = <0xe1608000 0x4000>;
> 
> In DTS sources: compatible then reg. I mentioned it in previous version.

right, forgot about reg, sorry.

> Best regards,
> Krzysztof

Will send v3, thanks again for your review.

Best regards,
Codrin