linux-kernel - Re: [PATCH] netfilter: conditionally use ct and ctinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b795685f-6cdb-5493-8280-75749ddb0f6f@redhat.com>
Date:   Mon, 7 Mar 2022 05:39:49 -0800
From:   Tom Rix <trix@...hat.com>
To:     Florian Westphal <fw@...len.de>
Cc:     pablo@...filter.org, kadlec@...filter.org, davem@...emloft.net,
        kuba@...nel.org, netfilter-devel@...r.kernel.org,
        coreteam@...filter.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netfilter: conditionally use ct and ctinfo


On 3/7/22 4:46 AM, Florian Westphal wrote:
> trix@...hat.com <trix@...hat.com> wrote:
>> From: Tom Rix <trix@...hat.com>
>>
>> The setting ct and ctinfo are controlled by
>> CONF_NF_CONNTRACK.  So their use should also
>> be controlled.
> Any reason for this change?

Define and use are connected. Doing something to one without doing 
something to the other doesn't make sense.

Could removing the CONF_NF_CONNTRACK be done for the define side ?

Tom

> We try to avoid ifdef where possible, unless it avoids a compiler
> warning/build/linker issue.
>
> This doesn't change generated code for me (NF_CONNTRACK=n) either.
>