linux-kernel - Re: [PATCH] ASoC: atmel: Fix error handling in snd_proto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <582c39ac-3099-d54f-5de3-d54a4ace0a04@microchip.com>
Date:   Mon, 7 Mar 2022 13:45:48 +0000
From:   <Codrin.Ciubotariu@...rochip.com>
To:     <linmq006@...il.com>, <lgirdwood@...il.com>, <broonie@...nel.org>,
        <perex@...ex.cz>, <tiwai@...e.com>, <Nicolas.Ferre@...rochip.com>,
        <alexandre.belloni@...tlin.com>, <Claudiu.Beznea@...rochip.com>,
        <florian.meier@...lo.de>, <alsa-devel@...a-project.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: atmel: Fix error handling in snd_proto_probe

On 07.03.2022 15:04, Miaoqian Lin wrote:
> @@ -136,18 +138,21 @@ static int snd_proto_probe(struct platform_device *pdev)
>                  dai_fmt |= snd_soc_daifmt_parse_clock_provider_as_flag(np, NULL);
>          }
> 
> -       of_node_put(bitclkmaster);
> -       of_node_put(framemaster);
> -       dai->dai_fmt = dai_fmt;
> 
> -       of_node_put(codec_np);
> -       of_node_put(cpu_np);
> +       dai->dai_fmt = dai_fmt;

looks like there is an extra line that remains here

With this addressed, you can add:

Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>

Thanks!