linux-kernel - [PATCH] fs/affs: remove redundant assignment to ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon,  7 Mar 2022 15:07:42 +0000
From:   Colin Ian King <colin.i.king@...il.com>
To:     David Sterba <dsterba@...e.com>, linux-fsdevel@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] fs/affs: remove redundant assignment to ch

The assignment of ch after subtracting ('a' - 'A') is redundant and
can be removed. Fix this by replacing the -= operator with just -
to remove the assignment.

Signed-off-by: Colin Ian King <colin.i.king@...il.com>
---
 fs/affs/namei.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/affs/namei.c b/fs/affs/namei.c
index bcab18956b4f..a1270deba908 100644
--- a/fs/affs/namei.c
+++ b/fs/affs/namei.c
@@ -19,7 +19,7 @@ typedef int (*toupper_t)(int);
 static int
 affs_toupper(int ch)
 {
-	return ch >= 'a' && ch <= 'z' ? ch -= ('a' - 'A') : ch;
+	return ch >= 'a' && ch <= 'z' ? ch - ('a' - 'A') : ch;
 }
 
 /* International toupper() for DOS\3 ("international") */
-- 
2.35.1