linux-kernel - Re: [PATCH] fs/affs: remove redundant assignment to ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220329165145.GZ2237@suse.cz>
Date:   Tue, 29 Mar 2022 18:51:46 +0200
From:   David Sterba <dsterba@...e.cz>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     David Sterba <dsterba@...e.com>, linux-fsdevel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/affs: remove redundant assignment to ch

On Mon, Mar 07, 2022 at 03:07:42PM +0000, Colin Ian King wrote:
> The assignment of ch after subtracting ('a' - 'A') is redundant and
> can be removed. Fix this by replacing the -= operator with just -
> to remove the assignment.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  fs/affs/namei.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/affs/namei.c b/fs/affs/namei.c
> index bcab18956b4f..a1270deba908 100644
> --- a/fs/affs/namei.c
> +++ b/fs/affs/namei.c
> @@ -19,7 +19,7 @@ typedef int (*toupper_t)(int);
>  static int
>  affs_toupper(int ch)
>  {
> -	return ch >= 'a' && ch <= 'z' ? ch -= ('a' - 'A') : ch;
> +	return ch >= 'a' && ch <= 'z' ? ch - ('a' - 'A') : ch;

AFFS is in fixes-only mode, I wonder how much this change is affecting
anybody, from the user perspective. I'd say not at all, W=1 build is
clean and that's something I'd be fine to fix, W=2 and W=3 warnings are
from other code.