linux-kernel - Re: [PATCH] mm/vmalloc: fix comments about vmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YiYpL3I/OrPJPWXo@pc638.lan>
Date:   Mon, 7 Mar 2022 16:47:59 +0100
From:   Uladzislau Rezki <urezki@...il.com>
To:     Bang Li <libang.linuxer@...il.com>
Cc:     akpm@...ux-foundation.org, urezki@...il.com, lpf.vector@...il.com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/vmalloc: fix comments about vmap_area struct

On Sat, Mar 05, 2022 at 09:15:10AM +0800, Bang Li wrote:
> the vmap_area_root should be in the "busy" tree and the free_vmap_area_root
> should be in the "free" tree.
> 
> Fixes: 688fcbfc06e4 ("mm/vmalloc: modify struct vmap_area to reduce its size")
> Signed-off-by: Bang Li <libang.linuxer@...il.com>
> ---
>  include/linux/vmalloc.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h
> index 880227b9f044..05065915edd7 100644
> --- a/include/linux/vmalloc.h
> +++ b/include/linux/vmalloc.h
> @@ -80,8 +80,8 @@ struct vmap_area {
>  	/*
>  	 * The following two variables can be packed, because
>  	 * a vmap_area object can be either:
> -	 *    1) in "free" tree (root is vmap_area_root)
> -	 *    2) or "busy" tree (root is free_vmap_area_root)
> +	 *    1) in "free" tree (root is free_vmap_area_root)
> +	 *    2) or "busy" tree (root is vmap_area_root)
>  	 */
>  	union {
>  		unsigned long subtree_max_size; /* in "free" tree */
> -- 
> 2.25.1
> 
Agree, those comments were messed up. 

Reviewed-by: Uladzislau Rezki (Sony) <urezki@...il.com>

--
Vlad Rezki