linux-kernel - RE: [PATCH v9 2/2] clocksource: Add Intel Keem Bay timer support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB5545C28013C6FD435154FB1BF1089@BN9PR11MB5545.namprd11.prod.outlook.com>
Date:   Mon, 7 Mar 2022 16:33:38 +0000
From:   "Sanil, Shruthi" <shruthi.sanil@...el.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC:     "daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "mgross@...ux.intel.com" <mgross@...ux.intel.com>,
        "Thokala, Srikanth" <srikanth.thokala@...el.com>,
        "Raja Subramanian, Lakshmi Bai" 
        <lakshmi.bai.raja.subramanian@...el.com>,
        "Sangannavar, Mallikarjunappa" 
        <mallikarjunappa.sangannavar@...el.com>
Subject: RE: [PATCH v9 2/2] clocksource: Add Intel Keem Bay timer support

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Sent: Monday, March 7, 2022 7:15 PM
> To: Sanil, Shruthi <shruthi.sanil@...el.com>
> Cc: daniel.lezcano@...aro.org; tglx@...utronix.de; robh+dt@...nel.org;
> linux-kernel@...r.kernel.org; devicetree@...r.kernel.org;
> mgross@...ux.intel.com; Thokala, Srikanth <srikanth.thokala@...el.com>;
> Raja Subramanian, Lakshmi Bai <lakshmi.bai.raja.subramanian@...el.com>;
> Sangannavar, Mallikarjunappa <mallikarjunappa.sangannavar@...el.com>
> Subject: Re: [PATCH v9 2/2] clocksource: Add Intel Keem Bay timer support
> 
> On Mon, Mar 07, 2022 at 05:01:47PM +0530, shruthi.sanil@...el.com wrote:
> > From: Shruthi Sanil <shruthi.sanil@...el.com>
> >
> > The Intel Keem Bay timer driver supports clocksource and clockevent
> > features for the timer IP used in Intel Keem Bay SoC.
> > The timer block supports 1 free running counter and 8 timers.
> > The free running counter can be used as a clocksource and the timers
> > can be used as clockevent. Each timer is capable of generating
> > individual interrupt.
> > Both the features are enabled through the timer general config register.
> 
> ...
> 
> > +		pr_err("%pOF: FW_BUG: Prescaler is not enabled\n", np);
> 
> FW_BUG is a macro. The above is an incorrect use of it.

Oh! I'll correct it and send the updated patch.

> 
> ...
> 
> > +		pr_err("%pOF: FW_BUG: free running counter is not
> enabled\n", np);
> 
> Ditto.
> 
> --
> With Best Regards,
> Andy Shevchenko
>