linux-kernel - Re: [PATCH] ACPI: APEI: fix return value of _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fsnu7cnr.fsf@yhuang6-desk2.ccr.corp.intel.com>
Date:   Mon, 07 Mar 2022 09:51:36 +0800
From:   "Huang, Ying" <ying.huang@...el.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org,
        Igor Zhbanov <i.zhbanov@...russia.ru>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
        James Morse <james.morse@....com>,
        Tony Luck <tony.luck@...el.com>, Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH] ACPI: APEI: fix return value of __setup handlers

Randy Dunlap <rdunlap@...radead.org> writes:

> __setup() handlers should return 1 to indicate that the boot option
> has been handled. Returning 0 causes a boot option to be listed in
> the Unknown kernel command line parameters and also added to init's
> arg list (if no '=' sign) or environment list (if of the form 'a=b').
>
> Unknown kernel command line parameters "erst_disable
>   bert_disable hest_disable BOOT_IMAGE=/boot/bzImage-517rc6", will be
>   passed to user space.
>
>  Run /sbin/init as init process
>    with arguments:
>      /sbin/init
>      erst_disable
>      bert_disable
>      hest_disable
>    with environment:
>      HOME=/
>      TERM=linux
>      BOOT_IMAGE=/boot/bzImage-517rc6
>
> Fixes: a3e2acc5e37b ("ACPI / APEI: Add Boot Error Record Table (BERT) support")
> Fixes: a08f82d08053 ("ACPI, APEI, Error Record Serialization Table (ERST) support")
> Fixes: 9dc966641677 ("ACPI, APEI, HEST table parsing")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>

Good catch!  Thanks for fixing!

Reviewed-by: "Huang, Ying" <ying.huang@...el.com>

Best Regards,
Huang, Ying

> Reported-by: Igor Zhbanov <i.zhbanov@...russia.ru>
> Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@...russia.ru
> Cc: Huang Ying <ying.huang@...el.com>
> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> Cc: Len Brown <lenb@...nel.org>
> Cc: linux-acpi@...r.kernel.org
> Cc: James Morse <james.morse@....com>
> Cc: Tony Luck <tony.luck@...el.com>
> Cc: Borislav Petkov <bp@...en8.de>
> ---
>  drivers/acpi/apei/bert.c |    2 +-
>  drivers/acpi/apei/erst.c |    2 +-
>  drivers/acpi/apei/hest.c |    2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> --- lnx-517-rc6.orig/drivers/acpi/apei/bert.c
> +++ lnx-517-rc6/drivers/acpi/apei/bert.c
> @@ -77,7 +77,7 @@ static int __init setup_bert_disable(cha
>  {
>  	bert_disable = 1;
>  
> -	return 0;
> +	return 1;
>  }
>  __setup("bert_disable", setup_bert_disable);
>  
> --- lnx-517-rc6.orig/drivers/acpi/apei/erst.c
> +++ lnx-517-rc6/drivers/acpi/apei/erst.c
> @@ -891,7 +891,7 @@ EXPORT_SYMBOL_GPL(erst_clear);
>  static int __init setup_erst_disable(char *str)
>  {
>  	erst_disable = 1;
> -	return 0;
> +	return 1;
>  }
>  
>  __setup("erst_disable", setup_erst_disable);
> --- lnx-517-rc6.orig/drivers/acpi/apei/hest.c
> +++ lnx-517-rc6/drivers/acpi/apei/hest.c
> @@ -224,7 +224,7 @@ err:
>  static int __init setup_hest_disable(char *str)
>  {
>  	hest_disable = HEST_DISABLED;
> -	return 0;
> +	return 1;
>  }
>  
>  __setup("hest_disable", setup_hest_disable);