linux-kernel - Re: [PATCH] ACPI: APEI: fix return value of _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hpesOogFv1g6h96xJnuaJ=paqWc3Bg2rOzMus4FMqTuQ@mail.gmail.com>
Date:   Tue, 8 Mar 2022 19:45:58 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     "Huang, Ying" <ying.huang@...el.com>,
        Randy Dunlap <rdunlap@...radead.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Igor Zhbanov <i.zhbanov@...russia.ru>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        James Morse <james.morse@....com>,
        Tony Luck <tony.luck@...el.com>, Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH] ACPI: APEI: fix return value of __setup handlers

On Mon, Mar 7, 2022 at 2:51 AM Huang, Ying <ying.huang@...el.com> wrote:
>
> Randy Dunlap <rdunlap@...radead.org> writes:
>
> > __setup() handlers should return 1 to indicate that the boot option
> > has been handled. Returning 0 causes a boot option to be listed in
> > the Unknown kernel command line parameters and also added to init's
> > arg list (if no '=' sign) or environment list (if of the form 'a=b').
> >
> > Unknown kernel command line parameters "erst_disable
> >   bert_disable hest_disable BOOT_IMAGE=/boot/bzImage-517rc6", will be
> >   passed to user space.
> >
> >  Run /sbin/init as init process
> >    with arguments:
> >      /sbin/init
> >      erst_disable
> >      bert_disable
> >      hest_disable
> >    with environment:
> >      HOME=/
> >      TERM=linux
> >      BOOT_IMAGE=/boot/bzImage-517rc6
> >
> > Fixes: a3e2acc5e37b ("ACPI / APEI: Add Boot Error Record Table (BERT) support")
> > Fixes: a08f82d08053 ("ACPI, APEI, Error Record Serialization Table (ERST) support")
> > Fixes: 9dc966641677 ("ACPI, APEI, HEST table parsing")
> > Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>
> Good catch!  Thanks for fixing!
>
> Reviewed-by: "Huang, Ying" <ying.huang@...el.com>

Applied as 5.18 material, thanks!