linux-kernel - Re: [PATCH] virtio_ring: Initialize vring_size_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YiZG0Nx9j++bJaA4@dev-arch.thelio-3990X>
Date:   Mon, 7 Mar 2022 10:54:24 -0700
From:   Nathan Chancellor <nathan@...nel.org>
To:     trix@...hat.com
Cc:     mst@...hat.com, jasowang@...hat.com, ndesaulniers@...gle.com,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] virtio_ring: Initialize vring_size_in_bytes

On Mon, Mar 07, 2022 at 09:49:16AM -0800, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> On the clang build, there is this error
> virtio_ring.c:1772:26: error: variable 'ring_size_in_bytes'
>   is uninitialized when used here
>   vring_free_queue(vdev, ring_size_in_bytes,
>                          ^~~~~~~~~~~~~~~~~~
> 
> ring_dma_addr was intialized twice, once with the ring_size_in_bytes.
> value.  So fix typo.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

I was getting ready to send the same patch.

Reviewed-by: Nathan Chancellor <nathan@...nel.org>

> ---
>  drivers/virtio/virtio_ring.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index 905c882600618..b2b567ebb9120 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -1756,7 +1756,7 @@ static void vring_free_vring_packed(struct vring_packed *vring,
>  	ring                  = vring->ring;
>  	driver                = vring->driver;
>  	device                = vring->device;
> -	ring_dma_addr         = vring->ring_size_in_bytes;
> +	ring_size_in_bytes    = vring->ring_size_in_bytes;
>  	event_size_in_bytes   = vring->event_size_in_bytes;
>  	ring_dma_addr         = vring->ring_dma_addr;
>  	driver_event_dma_addr = vring->driver_event_dma_addr;
> -- 
> 2.26.3
> 
>