linux-kernel - Re: [PATCH] perf tools: fix array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YiZHHs/UlL/zE/jh@kernel.org>
Date:   Mon, 7 Mar 2022 14:55:42 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Guo Zhengkui <guozhengkui@...o.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        "open list:PERFORMANCE EVENTS SUBSYSTEM" 
        <linux-perf-users@...r.kernel.org>,
        "open list:PERFORMANCE EVENTS SUBSYSTEM" 
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf tools: fix array_size.cocci warning

Em Mon, Mar 07, 2022 at 11:39:59AM +0800, Guo Zhengkui escreveu:
> Fix the following coccicheck warning:
> tools/perf/util/trace-event-parse.c:209:35-36: WARNING: Use ARRAY_SIZE
> 
> ARRAY_SIZE(arr) is a macro provided in tools/include/linux/kernel.h,
> which not only measures the size of the array, but also makes sure
> that `arr` is really an array.

Thanks, applied.
 
> It has been tested with gcc (Debian 8.3.0-6) 8.3.0.
> 
> Signed-off-by: Guo Zhengkui <guozhengkui@...o.com>
> ---
>  tools/perf/util/trace-event-parse.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/trace-event-parse.c b/tools/perf/util/trace-event-parse.c
> index 9634f0ae57be..c9c83a40647c 100644
> --- a/tools/perf/util/trace-event-parse.c
> +++ b/tools/perf/util/trace-event-parse.c
> @@ -206,7 +206,7 @@ unsigned long long eval_flag(const char *flag)
>  	if (isdigit(flag[0]))
>  		return strtoull(flag, NULL, 0);
>  
> -	for (i = 0; i < (int)(sizeof(flags)/sizeof(flags[0])); i++)
> +	for (i = 0; i < (int)(ARRAY_SIZE(flags)); i++)
>  		if (strcmp(flags[i].name, flag) == 0)
>  			return flags[i].value;
>  
> -- 
> 2.20.1

-- 

- Arnaldo