linux-kernel - RE: [Patch v4 4/4] memory: tegra: Add MC error logging on tegra186 onward

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SA0PR12MB4349E55BD1968FDC1962DC7ECA089@SA0PR12MB4349.namprd12.prod.outlook.com>
Date:   Mon, 7 Mar 2022 19:47:08 +0000
From:   Ashish Mhetre <amhetre@...dia.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        "kbuild@...ts.01.org" <kbuild@...ts.01.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        "digetx@...il.com" <digetx@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
CC:     "lkp@...el.com" <lkp@...el.com>,
        "kbuild-all@...ts.01.org" <kbuild-all@...ts.01.org>,
        Krishna Reddy <vdumpa@...dia.com>,
        Sachin Nikam <Snikam@...dia.com>
Subject: RE: [Patch v4 4/4] memory: tegra: Add MC error logging on tegra186
 onward

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> Sent: Thursday, March 3, 2022 6:33 PM
> To: Dan Carpenter <dan.carpenter@...cle.com>; kbuild@...ts.01.org; Ashish
> Mhetre <amhetre@...dia.com>; robh+dt@...nel.org;
> thierry.reding@...il.com; Jonathan Hunter <jonathanh@...dia.com>;
> digetx@...il.com; linux-kernel@...r.kernel.org; devicetree@...r.kernel.org;
> linux-tegra@...r.kernel.org
> Cc: lkp@...el.com; kbuild-all@...ts.01.org; Krishna Reddy
> <vdumpa@...dia.com>; Sachin Nikam <Snikam@...dia.com>
> Subject: Re: [Patch v4 4/4] memory: tegra: Add MC error logging on tegra186
> onward
> 
> External email: Use caution opening links or attachments
> 
> 
> On 03/03/2022 13:31, Dan Carpenter wrote:
> > Hi Ashish,
> >
> > url:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.
> com%2F0day-ci%2Flinux%2Fcommits%2FAshish-Mhetre%2Fmemory-tegra-
> Add-MC-channels-and-error-logging%2F20220302-
> 164625&amp;data=04%7C01%7Camhetre%40nvidia.com%7C448e9570ac274b
> 7ed2f408d9fd162da7%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C
> 637819094016979779%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM
> DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=
> dzcWTAMPikKWLFc4mkD%2FJPWQckiYrUzI9OOEEGvvDAA%3D&amp;reserved
> =0
> > base:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kern
> el.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftegra%2Flinux.git&amp;dat
> a=04%7C01%7Camhetre%40nvidia.com%7C448e9570ac274b7ed2f408d9fd162
> da7%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C63781909401697
> 9779%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luM
> zIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=pbpW4cT7C%2Fa
> qP8FJClKKdG4NdXpEGh0yBZPPk%2FeCSvU%3D&amp;reserved=0 for-next
> > config: openrisc-randconfig-m031-20220302
> > (https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdow
> > nload.01.org%2F0day-
> ci%2Farchive%2F20220303%2F202203031247.0bBX70B3-lk
> >
> p%40intel.com%2Fconfig&amp;data=04%7C01%7Camhetre%40nvidia.com%7C
> 448e9
> >
> 570ac274b7ed2f408d9fd162da7%7C43083d15727340c1b7db39efd9ccc17a%7C
> 0%7C0
> >
> %7C637819094016979779%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA
> wMDAiLCJQ
> >
> IjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=TO1bX5
> %2FM
> > PhUpf%2BnwSuHkB%2ByLEe4Mdn6Or%2BiZUrbeHpY%3D&amp;reserved=0)
> > compiler: or1k-linux-gcc (GCC) 11.2.0
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@...el.com>
> > Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> >
> > New smatch warnings:
> > drivers/memory/tegra/mc.c:593 tegra30_mc_handle_irq() error: uninitialized
> symbol 'channel'.
> 
> Ashish,
> 
> I mentioned with your v3 that it is expected for submitter to run certain
> automatic tools:
> "We not only expect to compile it but also compile with W=1, run sparse,
> smatch and coccicheck. Then also test."
> 
> Judging by the output here, it could be that either you used old compiler or did
> not run the checks.
> 
> Can you please confirm that you performed all the activities mentioned before?
> 
Hi Krzysztof,

I had tested the code and verified that MC errors are getting logged as expected
with my changes.
I had also compiled kernel with W=1, ran sparse and made sure that there
aren't any warnings/errors with my changes.
However, I didn't run smatch and coccicheck because I was facing difficulties
in setting up these tools.
I'll make sure that patches in future are scrutinized by all of these tools.

> Best regards,
> Krzysztof