linux-kernel - Re: [PATCHv5 07/30] x86/traps: Add #VE support for TDX guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d46eef1d-081e-337c-cc36-a19373be8a1a@intel.com>
Date:   Tue, 8 Mar 2022 12:29:46 -0800
From:   Dave Hansen <dave.hansen@...el.com>
To:     "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
        luto@...nel.org, peterz@...radead.org
Cc:     sathyanarayanan.kuppuswamy@...ux.intel.com, aarcange@...hat.com,
        ak@...ux.intel.com, dan.j.williams@...el.com, david@...hat.com,
        hpa@...or.com, jgross@...e.com, jmattson@...gle.com,
        joro@...tes.org, jpoimboe@...hat.com, knsathya@...nel.org,
        pbonzini@...hat.com, sdeep@...are.com, seanjc@...gle.com,
        tony.luck@...el.com, vkuznets@...hat.com, wanpengli@...cent.com,
        thomas.lendacky@....com, brijesh.singh@....com, x86@...nel.org,
        linux-kernel@...r.kernel.org,
        Sean Christopherson <sean.j.christopherson@...el.com>
Subject: Re: [PATCHv5 07/30] x86/traps: Add #VE support for TDX guest

On 3/2/22 06:27, Kirill A. Shutemov wrote:
> Virtualization Exceptions (#VE) are delivered to TDX guests due to
> specific guest actions which may happen in either user space or the
> kernel:
> 
>  * Specific instructions (WBINVD, for example)
>  * Specific MSR accesses
>  * Specific CPUID leaf accesses
>  * Access to specific guest physical addresses
...
>  arch/x86/coco/tdx.c             | 31 +++++++++++++
>  arch/x86/include/asm/idtentry.h |  4 ++
>  arch/x86/include/asm/tdx.h      | 21 +++++++++
>  arch/x86/kernel/idt.c           |  3 ++
>  arch/x86/kernel/traps.c         | 81 +++++++++++++++++++++++++++++++++

I know it took a long time to get here, but it's really, really nice
that this ended up being all done in C without any nastiness in the
kernel to deal with things like NMIs.

Reviewed-by: Dave Hansen <dave.hansen@...ux.intel.com>