linux-kernel - [PATCH] media: s5p-mfc: Handle error for clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220308075538.1117983-1-jiasheng@iscas.ac.cn>
Date:   Tue,  8 Mar 2022 15:55:38 +0800
From:   Jiasheng Jiang <jiasheng@...as.ac.cn>
To:     m.szyprowski@...sung.com, andrzej.hajda@...el.com,
        mchehab@...nel.org
Cc:     linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, Jiasheng Jiang <jiasheng@...as.ac.cn>
Subject: [PATCH] media: s5p-mfc: Handle error for clk_enable

As the potential failure of the clk_enable(),
it should be better to check it and return error
if fails.

Fixes: 1bce6fb3edf1 ("[media] s5p-mfc: Rework clock handling")
Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>
---
 drivers/media/platform/s5p-mfc/s5p_mfc_pm.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_pm.c b/drivers/media/platform/s5p-mfc/s5p_mfc_pm.c
index 88b7d33c9197..392e6fab0a75 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_pm.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_pm.c
@@ -106,10 +106,12 @@ int s5p_mfc_power_on(void)
 
 int s5p_mfc_power_off(void)
 {
-	int i;
+	int i, ret;
 
 	/* finish software clock gating */
-	clk_enable(pm->clock_gate);
+	ret = clk_enable(pm->clock_gate);
+	if (ret)
+		return ret;
 
 	for (i = 0; i < pm->num_clocks; i++)
 		clk_disable_unprepare(pm->clocks[i]);
-- 
2.25.1