linux-kernel - Re: [PATCH v5 1/2] fs/proc: optimize register ctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Mar 2022 19:22:51 +0800
From:   kernel test robot <lkp@...el.com>
To:     Meng Tang <tangmeng@...ontech.com>, mcgrof@...nel.org,
        keescook@...omium.org, yzaikin@...gle.com, ebiederm@...ssion.com,
        willy@...radead.org
Cc:     kbuild-all@...ts.01.org, nixiaoming@...wei.com,
        nizhen@...ontech.com, zhanglianjie@...ontech.com,
        sujiaxun@...ontech.com, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, Meng Tang <tangmeng@...ontech.com>
Subject: Re: [PATCH v5 1/2] fs/proc: optimize register ctl_tables

Hi Meng,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on mcgrof/sysctl-next]
[also build test WARNING on jack-fs/fsnotify rostedt-trace/for-next kees/for-next/pstore linus/master v5.17-rc7 next-20220308]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Meng-Tang/fs-proc-optimize-register-ctl_tables/20220307-150704
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git sysctl-next
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20220308/202203081905.IbWENTfU-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/1c32e4182bcc38ac7cf4385267fa8b4ca2d7d97a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Meng-Tang/fs-proc-optimize-register-ctl_tables/20220307-150704
        git checkout 1c32e4182bcc38ac7cf4385267fa8b4ca2d7d97a
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash fs/proc/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> fs/proc/proc_sysctl.c:1442: warning: expecting prototype for register_sysctl(). Prototype was for register_sysctl_with_num() instead


vim +1442 fs/proc/proc_sysctl.c

1f87f0b52b1d65 Eric W. Biederman 2012-01-06  1428  
fea478d4101a42 Eric W. Biederman 2012-01-20  1429  /**
fea478d4101a42 Eric W. Biederman 2012-01-20  1430   * register_sysctl - register a sysctl table
fea478d4101a42 Eric W. Biederman 2012-01-20  1431   * @path: The path to the directory the sysctl table is in.
fea478d4101a42 Eric W. Biederman 2012-01-20  1432   * @table: the table structure
1c32e4182bcc38 Meng Tang         2022-03-04  1433   * @register_by_num: register single one and table must be without child
fea478d4101a42 Eric W. Biederman 2012-01-20  1434   *
fea478d4101a42 Eric W. Biederman 2012-01-20  1435   * Register a sysctl table. @table should be a filled in ctl_table
fea478d4101a42 Eric W. Biederman 2012-01-20  1436   * array. A completely 0 filled entry terminates the table.
fea478d4101a42 Eric W. Biederman 2012-01-20  1437   *
fea478d4101a42 Eric W. Biederman 2012-01-20  1438   * See __register_sysctl_table for more details.
fea478d4101a42 Eric W. Biederman 2012-01-20  1439   */
1c32e4182bcc38 Meng Tang         2022-03-04  1440  struct ctl_table_header *register_sysctl_with_num(const char *path,
1c32e4182bcc38 Meng Tang         2022-03-04  1441  		struct ctl_table *table, int register_by_num)
fea478d4101a42 Eric W. Biederman 2012-01-20 @1442  {
1c32e4182bcc38 Meng Tang         2022-03-04  1443  	return __register_sysctl_table_with_num(&sysctl_table_root.default_set,
1c32e4182bcc38 Meng Tang         2022-03-04  1444  					path, table, register_by_num);
fea478d4101a42 Eric W. Biederman 2012-01-20  1445  }
1c32e4182bcc38 Meng Tang         2022-03-04  1446  EXPORT_SYMBOL(register_sysctl_with_num);
fea478d4101a42 Eric W. Biederman 2012-01-20  1447  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org