linux-kernel - Re: [PATCH v4 12/24] EDAC/amd64: Define function to get number of interleaved channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YikmbdnyNQx+Q/jJ@yaz-ubuntu>
Date:   Wed, 9 Mar 2022 22:13:01 +0000
From:   Yazen Ghannam <yazen.ghannam@....com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
        mchehab@...nel.org, tony.luck@...el.com, james.morse@....com,
        rric@...nel.org, Smita.KoralahalliChannabasappa@....com
Subject: Re: [PATCH v4 12/24] EDAC/amd64: Define function to get number of
 interleaved channels

On Mon, Feb 14, 2022 at 01:20:44PM +0100, Borislav Petkov wrote:
> On Thu, Jan 27, 2022 at 08:41:03PM +0000, Yazen Ghannam wrote:
> > Move number of interleaved channel calculation to a separate helper
> > function. Drop unused cases.
> 
> ... or by looking at that change, I think you want to have each separate
> step in the address massaging be a separate function. Which, if so,
> makes sense but you have to say it...
>

Yep, will do.
 
> ...
> 
> > +static void get_intlv_num_chan(struct addr_ctx *ctx)
> > +{
> > +	/* Save the log2(# of channels). */
> > +	switch (ctx->intlv_mode) {
> > +	case NONE:
> > +		ctx->intlv_num_chan = 0;
> > +		break;
> > +	case NOHASH_2CH:
> > +	case DF2_HASH_2CH:
> > +		ctx->intlv_num_chan = 1;
> > +		break;
> > +	default:
> > +		/* Valid interleaving modes where checked earlier. */
> 
> "were"

Will fix.

Thanks,
Yazen