linux-kernel - Re: [PATCH v4 10/24] EDAC/amd64: Define function to get Interleave Address Bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YikmMHYpdehehD9F@yaz-ubuntu>
Date:   Wed, 9 Mar 2022 22:12:00 +0000
From:   Yazen Ghannam <yazen.ghannam@....com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
        mchehab@...nel.org, tony.luck@...el.com, james.morse@....com,
        rric@...nel.org, Smita.KoralahalliChannabasappa@....com
Subject: Re: [PATCH v4 10/24] EDAC/amd64: Define function to get Interleave
 Address Bit

On Mon, Feb 14, 2022 at 01:10:49PM +0100, Borislav Petkov wrote:
> On Thu, Jan 27, 2022 at 08:41:01PM +0000, Yazen Ghannam wrote:
> > Move code to find the interleave address bit into a separate helper
> > function.
> 
> Same question: what's the point of this change?
>

Yes, I'll update this.

Similar goal as in other places. When the function seems sufficiently long
(subjective I know), break it up into helper functions.

I've been trying to decide based on logical steps. Do you have any general
recommendations or rule-of-thumb?

Thanks,
Yazen