linux-kernel - Re: [PATCH V3] ata: pata_pxa: Use platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3bc54ce-3a13-e0d7-97e6-bd4d553f577c@omp.ru>
Date:   Wed, 9 Mar 2022 11:51:10 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     <cgel.zte@...il.com>, <damien.lemoal@...nsource.wdc.com>
CC:     <chi.minghao@....com.cn>, <linux-ide@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <zealci@....com.cn>
Subject: Re: [PATCH V3] ata: pata_pxa: Use platform_get_irq() to get the
 interrupt

On 09.03.2022 10:28, cgel.zte@...il.com wrote:

> From: Minghao Chi <chi.minghao@....com.cn>
> 
> platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
> allocation of IRQ resources in DT core code, this causes an issue
> when using hierarchical interrupt domains using "interrupts" property
> in the node as this bypasses the hierarchical setup and messes up the
> irq chaining.
> 
> In preparation for removal of static setup of IRQ resource from DT core
> code use platform_get_irq().
> 
> v1->v2:
>      - Use more specific in the subject: ata: pata_pxa:
>      - Switch to returning 'irq'
> v2->v3:
>      - drop the unlikely()
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>

Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

[...]

MBR, Sergey