linux-kernel - Re: [PATCH v2 1/2] mm: slab: Delete unused SLAB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220310142747.GA1166219@odroid>
Date:   Thu, 10 Mar 2022 14:27:47 +0000
From:   Hyeonggon Yoo <42.hyeyoo@...il.com>
To:     sxwjean@...com
Cc:     cl@...ux.com, penberg@...nel.org, rientjes@...gle.com,
        iamjoonsoo.kim@....com, akpm@...ux-foundation.org, vbabka@...e.cz,
        longman@...hat.com, guro@...com, willy@...radead.org,
        roman.gushchin@...ux.dev, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Xiongwei Song <sxwjean@...il.com>
Subject: Re: [PATCH v2 1/2] mm: slab: Delete unused SLAB_DEACTIVATED flag

On Thu, Mar 10, 2022 at 10:07:00PM +0800, sxwjean@...com wrote:
> From: Xiongwei Song <sxwjean@...il.com>
> 
> Since commit 9855609bde03 ("mm: memcg/slab: use a single set of
> kmem_caches for all accounted allocations") deleted all SLAB_DEACTIVATED
> users, therefore this flag is not needed any more, let's delete it.
> 

Looks nice!

Acked-by: Hyeonggon Yoo <42.hyeyoo@...il.com>

> Signed-off-by: Xiongwei Song <sxwjean@...il.com>
> Acked-by: David Rientjes <rientjes@...gle.com>
> Reviewed-by: Roman Gushchin <roman.gushchin@...ux.dev>
> ---
>  include/linux/slab.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/include/linux/slab.h b/include/linux/slab.h
> index 37bde99b74af..b6b3eed6c7c4 100644
> --- a/include/linux/slab.h
> +++ b/include/linux/slab.h
> @@ -117,9 +117,6 @@
>  #define SLAB_RECLAIM_ACCOUNT	((slab_flags_t __force)0x00020000U)
>  #define SLAB_TEMPORARY		SLAB_RECLAIM_ACCOUNT	/* Objects are short-lived */
>  
> -/* Slab deactivation flag */
> -#define SLAB_DEACTIVATED	((slab_flags_t __force)0x10000000U)
> -
>  /*
>   * ZERO_SIZE_PTR will be returned for zero sized kmalloc requests.
>   *
> -- 
> 2.30.2
> 
>