linux-kernel - Re: [PATCH] tcp: export symbol tcp_set_congestion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220311081815.20e26640@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 11 Mar 2022 08:18:15 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Christoph Hellwig <hch@....de>
Cc:     Mingbao Sun <sunmingbao@....com>,
        Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, tyler.sun@...l.com,
        ping.gan@...l.com, yanxiu.cai@...l.com, libin.zhang@...l.com,
        ao.sun@...l.com
Subject: Re: [PATCH] tcp: export symbol tcp_set_congestion_control

On Fri, 11 Mar 2022 08:19:30 +0100 Christoph Hellwig wrote:
> On Thu, Mar 10, 2022 at 12:48:25PM -0800, Jakub Kicinski wrote:
> > On Thu, 10 Mar 2022 21:48:30 +0800 Mingbao Sun wrote:  
> > > Since the kernel API 'kernel_setsockopt' was removed, and since the
> > > function ‘tcp_set_congestion_control’ is just the real underlying guy
> > > handling this job, so it makes sense to get it exported.  
> > 
> > Do you happen to have a reference to the commit which removed
> > kernel_setsockopt and the justification?  My knee jerk reaction
> > would the that's a better path than allowing in-kernel socket users 
> > to poke at internal functions even if that works as of today.  
> 
> This was part of the set_fs() removal. Back then we decided we'd rather
> have type-safe APIs for in-kernel users, which in total was a major
> removal of code lines.

I see, thanks. I guess no point speculating, we can revisit if
any bugs due to direct callers actually materialize.