linux-kernel - Re: [PATCH v4] drivers: ddcci: upstream DDCCI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YirxlzkYxl3MIjoR@kroah.com>
Date:   Fri, 11 Mar 2022 07:52:07 +0100
From:   gregkh <gregkh@...uxfoundation.org>
To:     Yusuf Khan <yusisamerican@...il.com>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jason Wang <jasowang@...hat.com>,
        Michael Kelley <mikelley@...rosoft.com>,
        "Michael S. Tsirkin" <mst@...hat.com>, javier@...igon.com,
        Arnd Bergmann <arnd@...db.de>, Will Deacon <will@...nel.org>,
        Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH v4] drivers: ddcci: upstream DDCCI driver

On Thu, Mar 10, 2022 at 05:19:47PM -0800, Yusuf Khan wrote:
> I (hopefully) fulfilled those requests in my subsequent patch,
> turns out I forgot to git add some of my changes. I did not
> remove the unlikely()s  as I think they look good and point
> to where error checking is that many may miss.

Never use a unlikely() or likely() macro unless you can prove, with a
benchmark, that it makes the code go faster.  If not, just remove them
as the compiler and CPU will always do a better job at this (we have
proof of it in the past.)

thanks,

greg k-h