linux-kernel - Re: [PATCH v4] drivers: ddcci: upstream DDCCI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJoG2+_NN2n64G+ROm5B_c_LGrvRGdU=DE=jk5VVe1T7aKNDEw@mail.gmail.com>
Date:   Thu, 10 Mar 2022 23:24:38 -0800
From:   Yusuf Khan <yusisamerican@...il.com>
To:     gregkh <gregkh@...uxfoundation.org>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jason Wang <jasowang@...hat.com>,
        Michael Kelley <mikelley@...rosoft.com>,
        "Michael S. Tsirkin" <mst@...hat.com>, javier@...igon.com,
        Arnd Bergmann <arnd@...db.de>, Will Deacon <will@...nel.org>,
        Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH v4] drivers: ddcci: upstream DDCCI driver

Fine

On Thu, Mar 10, 2022 at 10:52 PM gregkh <gregkh@...uxfoundation.org> wrote:
>
> On Thu, Mar 10, 2022 at 05:19:47PM -0800, Yusuf Khan wrote:
> > I (hopefully) fulfilled those requests in my subsequent patch,
> > turns out I forgot to git add some of my changes. I did not
> > remove the unlikely()s  as I think they look good and point
> > to where error checking is that many may miss.
>
> Never use a unlikely() or likely() macro unless you can prove, with a
> benchmark, that it makes the code go faster.  If not, just remove them
> as the compiler and CPU will always do a better job at this (we have
> proof of it in the past.)
>
> thanks,
>
> greg k-h