linux-kernel - Re: [PATCH 3/3] serial: 8250_fintek.c: Clean up set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Mar 2022 10:23:22 +0100
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Trevor Woerner <twoerner@...il.com>, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-serial@...r.kernel.org
Subject: Re: [PATCH 3/3] serial: 8250_fintek.c: Clean up set_termios() message

On 11. 03. 22, 8:02, Trevor Woerner wrote:
> Clean up the status message that is given in the case where a custom
> termios() is not installed.
> 
> Signed-off-by: Trevor Woerner <twoerner@...il.com>
> ---
>   drivers/tty/serial/8250/8250_fintek.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_fintek.c b/drivers/tty/serial/8250/8250_fintek.c
> index 03ad2354d808..dcab23d1965e 100644
> --- a/drivers/tty/serial/8250/8250_fintek.c
> +++ b/drivers/tty/serial/8250/8250_fintek.c
> @@ -333,7 +333,7 @@ static void fintek_8250_set_termios(struct uart_port *port,
>   	default:
>   		/* Don't change clocksource with unknown PID */
>   		dev_warn(port->dev,
> -			"%s: pid: %x Not support. use default set_termios.\n",
> +			"%s: chipID: %x not supported; using default set_termios.\n",
>   			__func__, pdata->pid);

So the variable calls it PID, the comment calls it PID and you change 
the report to chipID. Why?

thanks,
-- 
js
suse labs