linux-kernel - Re: [PATCH 3/3] serial: 8250_fintek.c: Clean up set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 11 Mar 2022 09:34:31 -0500
From:   Trevor Woerner <twoerner@...il.com>
To:     Jiri Slaby <jirislaby@...nel.org>
Cc:     linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial@...r.kernel.org
Subject: Re: [PATCH 3/3] serial: 8250_fintek.c: Clean up set_termios() message

On Fri 2022-03-11 @ 10:23:22 AM, Jiri Slaby wrote:
> On 11. 03. 22, 8:02, Trevor Woerner wrote:
> > Clean up the status message that is given in the case where a custom
> > termios() is not installed.
> > 
> > Signed-off-by: Trevor Woerner <twoerner@...il.com>
> > ---
> >   drivers/tty/serial/8250/8250_fintek.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/tty/serial/8250/8250_fintek.c b/drivers/tty/serial/8250/8250_fintek.c
> > index 03ad2354d808..dcab23d1965e 100644
> > --- a/drivers/tty/serial/8250/8250_fintek.c
> > +++ b/drivers/tty/serial/8250/8250_fintek.c
> > @@ -333,7 +333,7 @@ static void fintek_8250_set_termios(struct uart_port *port,
> >   	default:
> >   		/* Don't change clocksource with unknown PID */
> >   		dev_warn(port->dev,
> > -			"%s: pid: %x Not support. use default set_termios.\n",
> > +			"%s: chipID: %x not supported; using default set_termios.\n",
> >   			__func__, pdata->pid);
> 
> So the variable calls it PID, the comment calls it PID and you change the
> report to chipID. Why?

The datasheet doesn't contain the string/identifier PID anywhere. The hex
value stored in pdata->pid is the contents of what the datasheet refers to as
the Chip ID Register in the Global Control Registers. Identifying this value
as the chipID would probably make more sense to a person who is trying to
understand what this value is, provided they're also reading through the
datasheet at the same time.

I was considering a patch that would change "pid" to "chipID" in
8250_fintek.c, would that be a better way to go? I guess pid stands for "part
ID" or "product ID", but neither of those appear in the datasheet either.

> thanks,
> -- 
> js
> suse labs