linux-kernel - Re: [PATCH v7] drivers: ddcci: upstream DDCCI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b4e3cda7f5e8b630437cfc101f72810bc3f8d46.camel@perches.com>
Date:   Fri, 11 Mar 2022 03:16:22 -0800
From:   Joe Perches <joe@...ches.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Yusuf Khan <yusisamerican@...il.com>, linux-kernel@...r.kernel.org,
        jasowang@...hat.com, mikelley@...rosoft.com, mst@...hat.com,
        javier@...igon.com, arnd@...db.de, will@...nel.org, axboe@...nel.dk
Subject: Re: [PATCH v7] drivers: ddcci: upstream DDCCI driver

On Fri, 2022-03-11 at 12:01 +0100, Greg KH wrote:
> On Fri, Mar 11, 2022 at 02:45:01AM -0800, Joe Perches wrote:
> > On Fri, 2022-03-11 at 09:14 +0100, Greg KH wrote:
> > > On Thu, Mar 10, 2022 at 11:44:13PM -0800, Yusuf Khan wrote:
> > > > This patch upstreams the DDCCI driver by Christoph Grenz into
> > > > the kernel. The original gitlab page is loacted at https://gitlab
> > > > .com/ddcci-driver-linux/ddcci-driver-linux/-/tree/master.
> > []
> > > > diff --git a/drivers/char/ddcci.c b/drivers/char/ddcci.c
> > []
> > > > @@ -0,0 +1,1887 @@
> > > > +// SPDX-License-Identifier: GPL-2.0
> > > > +/*
> > > > + *  DDC/CI sub-bus driver
> > > > + *
> > > > + *  Copyright (c) 2015 Christoph Grenz
> > > > + */
> > > > +
> > > > +/*
> > > > + * This program is free software; you can redistribute it and/or modify it
> > > > + * under the terms of the GNU General Public License as published by the Free
> > > > + * Software Foundation; either version 2 of the License, or (at your option)
> > > > + * any later version.
> > > 
> > > This does not match the SPDX line.  Please fix up first before going any
> > > further.
> > 
> > Which means fix up the SPDX line above to use the actual
> > license of the code.
> > 
> > // SPDX-License-Identifier: GPL-2.0-or-later
> 
> If that is the intent, it depends on the original author, I have not
> seen the source for where this came from, have you?

Tes.

Just take 10 seconds to look at the link provided in the text above
before you take 10 seconds to ask me instead.

https://gitlab.com/ddcci-driver-linux/ddcci-driver-linux/-/tree/master

And it's a bit odd of you to suggest otherwise when the link is
clearly shown and the actual license text is clear with
"(at your option) any later version".