linux-kernel - Re: [PATCH v7] drivers: ddcci: upstream DDCCI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJoG2+9w=GP9=+d=pLuNRoR7USH1V7f=DSPURxnxotYs_CwW+w@mail.gmail.com>
Date:   Fri, 11 Mar 2022 21:09:45 -0800
From:   Yusuf Khan <yusisamerican@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jason Wang <jasowang@...hat.com>,
        Michael Kelley <mikelley@...rosoft.com>,
        "Michael S. Tsirkin" <mst@...hat.com>, javier@...igon.com,
        Arnd Bergmann <arnd@...db.de>, Will Deacon <will@...nel.org>,
        Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH v7] drivers: ddcci: upstream DDCCI driver

> How can this ever fail?
If ddcci_verify_device() fails
> Not needed, just do not have it.
I'm assuming you mean the locks?
> This should not be needed in sysfs.  What tool wants this?
Its for the idSerial and modalias part of the userland interface.
> Why "_void"?
suppressing "initialization of ‘void (*)(struct device *)’ from
incompatible pointer type ‘int (*)(struct device *)’"