linux-kernel - Re: [PATCH v4 3/9] gpu: host1x: Add context device management code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45e5f833-b492-30df-a1ed-108e05a2b465@gmail.com>
Date:   Sat, 12 Mar 2022 21:12:31 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     cyndis@...si.fi, thierry.reding@...il.com, jonathanh@...dia.com,
        joro@...tes.org, will@...nel.org, robin.murphy@....com,
        robh+dt@...nel.org, krzysztof.kozlowski@...onical.com
Cc:     linux-tegra@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Mikko Perttunen <mperttunen@...dia.com>
Subject: Re: [PATCH v4 3/9] gpu: host1x: Add context device management code

01.03.2022 19:14, cyndis@...si.fi пишет:
> +/* host1x context devices */
> +
> +struct host1x_context {
> +	struct host1x *host;
> +
> +	refcount_t ref;
> +	struct pid *owner;
> +
> +	struct device dev;
> +	u64 dma_mask;
> +	u32 stream_id;
> +};

I'm still not very happy about the "context" names. For example here
it's only about the "memory context", then why not to name struct as
host1x_memory_context or host1x_memctx?

It's not good to use generic names for a special things, it hurts
readability of the code. It's important to choose good names.