linux-kernel - Aw: Re: [PATCH v6 3/6] ARM: dts: spear13xx: Fix sata node name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <trinity-0f1389c2-6d2b-4499-a2fc-3cb93f4d09cb-1647272336831@3c-app-gmx-bap56>
Date:   Mon, 14 Mar 2022 16:38:56 +0100
From:   Frank Wunderlich <frank-w@...lic-files.de>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     Frank Wunderlich <linux@...web.de>, devicetree@...r.kernel.org,
        Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Viresh Kumar <vireshk@...nel.org>,
        Shiraz Hashim <shiraz.linux.kernel@...il.com>, soc@...nel.org,
        Andrew Lunn <andrew@...n.ch>,
        Gregory Clement <gregory.clement@...tlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Heiko Stuebner <heiko@...ech.de>,
        Peter Geis <pgwipeout@...il.com>,
        Michael Riesch <michael.riesch@...fvision.net>,
        Hans de Goede <hdegoede@...hat.com>,
        Jens Axboe <axboe@...nel.dk>, linux-ide@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org
Subject: Aw: Re: [PATCH v6 3/6] ARM: dts: spear13xx: Fix sata node name

Hi,

thanks for for checking the spear-patch.

> Gesendet: Montag, 14. März 2022 um 04:49 Uhr
> Von: "Viresh Kumar" <viresh.kumar@...aro.org>
>
> On 11-03-22, 22:03, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@...lic-files.de>
> > 
> > After converting the binding to yaml the node name does
> > not match the standard pattern, change it.
> > 
> > arch/arm/boot/dts/spear1340-evb.dt.yaml: ahci@...00000:
> > $nodename:0: 'ahci@...00000' does not match '^sata(@.*)?$'
> > 	From schema: Documentation/devicetree/bindings/ata/ahci-platform.yaml
> > 
> > Fixes: 07658d9a659b ("SPEAr13xx: Add dts and dtsi files")
> 
> I don't think this is correct. The above patch is correct. The first
> patch in this series changes the names and that's where things break.

it's right that my binding will break it, but the nodes are not named the right way.
And i used the commit that introduces the wrong node-names.
Maybe fixes-tag is wrong in this case.

> I think you could have added these patches before changing to yaml and
> then nothing would ever have broken.
> 
> Since this isn't a big deal anyway, I think you can just drop the
> Fixes tag here, and other dts patches you have.

regards Frank